Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restrict to specific list of providers and allow settings #498

Merged
merged 6 commits into from
Dec 12, 2024
Merged

restrict to specific list of providers and allow settings #498

merged 6 commits into from
Dec 12, 2024

Conversation

snamilikonda
Copy link

Pull Request Template

Description

Restricts usage of settings and extensions conditionally to a specific set

Checklist

  • [-] The code change is covered by unit tests. I have added tests that prove my fix is effective or that my feature works
  • [-] I have performed end-to-end test locally.
  • [-] New and existing unit tests pass locally with my changes
  • [-] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [-] My changes generate no new warnings
  • [-] I used clear names for everything
  • [-] I have performed a self-review of my own code

@snamilikonda snamilikonda marked this pull request as ready for review December 10, 2024 16:05
@snamilikonda snamilikonda requested a review from a team as a code owner December 10, 2024 16:05
@snamilikonda snamilikonda linked an issue Dec 10, 2024 that may be closed by this pull request
[Feature]: For pac cli restrict users, module, auth and providers extensions to a set list in pac cli #411
Closed
@snamilikonda snamilikonda changed the title User/snamilikonda/restrict to specific restrict to specific list of providers Dec 10, 2024
@snamilikonda snamilikonda changed the title restrict to specific list of providers restrict to specific list of providers and allow settings Dec 10, 2024
mcalderon00
mcalderon00 approved these changes Dec 12, 2024
View reviewed changes
Copy link

@mcalderon00 mcalderon00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor comments.

@snamilikonda snamilikonda merged commit 980c542 into integration Dec 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcalderon00 mcalderon00 mcalderon00 approved these changes

Assignees
No one assigned
Labels
review required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: For pac cli restrict users, module, auth and providers extensions to a set list in pac cli
2 participants
@snamilikonda @mcalderon00